Bug #2746

hylafax: notify fails if tsi has spaces

Added by Filippo Carletti over 5 years ago. Updated over 5 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-hylafax
Target version:v6.5
Security class: Resolution:
Affected version:v6.5-final NEEDINFO:No

Description

When the receiving fax machine has a tsi with spaces in the name, sender doesn't receive notification of success or failure.
The problem comes from missing double quotes in the notification handlers script.


Related issues

Related to NethServer 6 - Bug #2742: Hylafax: no automatic fax printing CLOSED
Related to NethServer 6 - Bug #2830: faxweb: non-admin users unable to see their faxes CLOSED

Associated revisions

Revision 7277004b
Added by Filippo Carletti over 5 years ago

notification scripts: fix parameters passing with quotes. Refs #2746

Revision d17d3430
Added by Filippo Carletti over 5 years ago

notification scripts: fix parameters passing with quotes. Refs #2746

History

#1 Updated by Filippo Carletti over 5 years ago

  • Status changed from NEW to TRIAGED
  • Target version set to v6.5
  • % Done changed from 0 to 20
  • Affected version set to v6.5-final

#2 Updated by Filippo Carletti over 5 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Filippo Carletti
  • % Done changed from 20 to 30

#3 Updated by Filippo Carletti over 5 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Filippo Carletti)
  • % Done changed from 30 to 60

Modified files:

/var/spool/hylafax/etc/notify/faxweb
/var/spool/hylafax/etc/accounting/faxweb
/var/spool/hylafax/etc/accounting/00savefiles
/var/spool/hylafax/etc/FaxAccounting (tmpl)
/var/spool/hylafax/etc/FaxAccounting (tmpl)

faxweb2 should display all statuses (sending, sent not sent with corresponding colours red-yellow-green).

  1. Send a fax to a real fax
  2. send a fax to a non existing number and wait for error
  3. send a fax to a non existing number and cancel sending
  4. receive a fax

Fax should copied in /var/lib/nethserver/fax/docs

#4 Updated by Filippo Carletti over 5 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70
Packages in nethserver-testing:
  • nethserver-hylafax-1.0.6-5.0gitd17d3430.ns6.noarch.rpm
  • nethserver-faxweb2-1.0.3-1.0git7277004b.ns6.noarch.rpm

See note #2746-3 for testing.

#5 Updated by Nicola Rauso over 5 years ago

  • Assignee set to Nicola Rauso

#6 Updated by Nicola Rauso over 5 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Nicola Rauso)
  • % Done changed from 70 to 90

Tested: ok

#7 Updated by Giacomo Sanchietti over 5 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Release in nethserver-updates:
  • nethserver-hylafax-1.0.7-1.ns6.noarch.rpm
  • nethserver-faxweb2-1.0.4-1.ns6.noarch.rpm

#8 Updated by Davide Principi over 5 years ago

  • Related to Bug #2830: faxweb: non-admin users unable to see their faxes added

#9 Updated by Davide Principi over 5 years ago

Giacomo Sanchietti wrote:

  • nethserver-faxweb2-1.0.4-1.ns6.noarch.rpm

Today version 1.0.5 has been released.

Also available in: Atom PDF