Bug #3422
Shared folders: trash doesn't exclude tmp file
Status: | CLOSED | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 100% | |
Category: | nethserver-samba | |||
Target version: | v6.8 | |||
Security class: | Resolution: | |||
Affected version: | v6.8 | NEEDINFO: | No |
Description
When the trash is enabled, the following files shouldn't go to the trash after deletion:
- *.tmp
- *.temp
- *.o
- *.obj
- ~*
The bug is caused by a syntax change for smb.conf.
Proposed and tested patch:
[root@mail ~]# diff /etc/e-smith/templates/etc/samba/smb.conf/ibay-default/01vfs_recycle /etc/e-smith/templates-custom/etc/samba/smb.conf/ibay-default/01vfs_recycle 17,18c17,18 < exclude => "*.tmp|*.temp|*.o|*.obj|~\$*", < exclude_dir => "/tmp|/temp|/cache", --- > exclude => "*.tmp,*.temp,*.o,*.obj,~\$*", > exclude_dir => "/tmp,/temp,/cache", 23c23 < } \ No newline at end of file --- > }References:
Associated revisions
Fix vfs_recycle excludes syntax. Refs #3422
Fix vfs_recycle excludes syntax. Refs #3422
History
#1 Updated by Giacomo Sanchietti almost 5 years ago
- Status changed from NEW to TRIAGED
- Target version set to v6.8
- % Done changed from 0 to 20
#2 Updated by Davide Principi almost 5 years ago
- Category changed from nethserver-ibays to nethserver-samba
- Status changed from TRIAGED to ON_DEV
- Assignee set to Davide Principi
- % Done changed from 20 to 30
#3 Updated by Davide Principi almost 5 years ago
- Status changed from ON_DEV to MODIFIED
- Assignee deleted (
Davide Principi) - % Done changed from 30 to 60
#4 Updated by Davide Principi almost 5 years ago
- Status changed from MODIFIED to ON_QA
- % Done changed from 60 to 70
In nethserver-testing:
nethserver-samba-1.5.5-1.2.g7356992.ns6.noarch.rpm
#5 Updated by Giacomo Sanchietti almost 5 years ago
- Assignee set to Giacomo Sanchietti
#6 Updated by Giacomo Sanchietti almost 5 years ago
- Status changed from ON_QA to VERIFIED
- Assignee deleted (
Giacomo Sanchietti) - % Done changed from 70 to 90
- Created a file named test
, the file goes to trash directory after delete
- Created a file named test.tmp
, the file doesn't go to trash after delete
#7 Updated by Giacomo Sanchietti almost 5 years ago
Cherry-picked commit 7356992d3915428163c76ea655465e21d28a1243 also on NS 7.
#8 Updated by Giacomo Sanchietti almost 5 years ago
- Status changed from VERIFIED to CLOSED
- % Done changed from 90 to 100
Released for NS 6:
- nethserver-samba-1.5.6-1.ns6.noarch.rpm
#9 Updated by Giacomo Sanchietti over 4 years ago
Released also for NS 7:
- nethserver-samba-2.0.2-1.ns7.noarch.rpm