Bug #3440

Samba disabled flag not updated

Added by Davide Principi over 2 years ago. Updated about 2 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-samba
Target version:v6.9
Security class: Resolution:
Affected version:v6.9 NEEDINFO:No

Description

Steps to reproduce

- create a user first.user with Samba enabled
- set a password
- set it locked

Expected behavior

The command pdbedit -L -v first.user shows the flag D.

Actual behavior

The user is still enabled

Account Flags:        [U          ]

Components

nethserver-samba-1.5.7-1.ns6.noarch

History

#1 Updated by Davide Principi over 2 years ago

Patch proposal

--- /etc/e-smith/events/actions/nethserver-samba-user-modify.orig    2017-05-19 15:57:23.213254827 +0200
+++ /etc/e-smith/events/actions/nethserver-samba-user-modify    2017-05-19 15:57:28.501238476 +0200
@@ -35,7 +35,7 @@

 my $prefix = NethServer::Samba->new()->get_sam_prefix();

-if(system($net . ' sam show "$prefix\\$user" &>/dev/null') != 0) {
+if(system($net . qq( sam show '$prefix\\$user' &>/dev/null)) != 0) {
     exit(0); # Ignore password modification if user does not exist in
          # SAM db.
 }

#2 Updated by Giacomo Sanchietti about 2 years ago

  • Status changed from TRIAGED to MODIFIED
  • % Done changed from 20 to 60

#3 Updated by Giacomo Sanchietti about 2 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

In nethserver-testing:
nethserver-samba-1.5.7-1.1.g56fccd1.ns6.noarch.rpm

Test case

Check the bug is not reproducible.

#4 Updated by Giacomo Sanchietti about 2 years ago

  • Status changed from ON_QA to VERIFIED
  • % Done changed from 70 to 90

Before locking:

...
Account Flags:        [U          ]
...

After locking:

...
Account Flags:        [DU          ]
...

#5 Updated by Giacomo Sanchietti about 2 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

Released:
nethserver-samba-1.5.8-1.ns6.noarch.rpm

Also available in: Atom PDF