Enhancement #3335

Mail common: remove template warning

Added by Davide Principi over 2 years ago. Updated about 2 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-mail-common
Target version:v6.7
Resolution: NEEDINFO:No

Description

The missing default value for postfix/AccessBypassList raises the following WARNING in /var/log/messages

Dec 23 15:35:26 vm5 esmith::event[10657]: WARNING in /etc/e-smith/templates//etc/postfix/access.cidr/10smtpaccess: Use of uninitialized value in split at /etc/e-smith/templates//etc/postfix/access.cidr/10smtpaccess line 6.

Add the default value for that prop.

Associated revisions

Revision 25540fd5
Added by Davide Principi about 2 years ago

Default value for postfix/AccessBypassList. Refs #3335

History

#1 Updated by Giacomo Sanchietti about 2 years ago

  • Subject changed from Remove template warning to Mail common: remove template warning

#2 Updated by Davide Principi about 2 years ago

  • Status changed from NEW to TRIAGED
  • Priority changed from Low to Normal
  • % Done changed from 0 to 20

#3 Updated by Davide Principi about 2 years ago

  • Status changed from TRIAGED to MODIFIED
  • % Done changed from 20 to 60

Test case

The modified version must not issue that warning during a clean installation

#4 Updated by Davide Principi about 2 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

In nethserver-testing:
nethserver-mail-common-1.5.2-1.2.g25540fd.ns6.noarch.rpm

#5 Updated by k c about 2 years ago

  • Assignee set to k c

I installed Email from the gui and verifed the above error is in the log messages with a search for "postfix/access.cidr/10smtpaccess", then reverted the vm.

from a fresh install I did;
[root@server32 ~]# yum --enablerepo=nethserver-testing install nethserver-mail-common

and therefore;


Loaded plugins: changelog, fastestmirror, nethserver_events, presto
Setting up Install Process
Loading mirror speeds from cached hostfile
 * centos-base: mirror.hmc.edu
 * centos-updates: centos-distro.cavecreek.net
 * nethserver-base: nethserver.antani.co
 * nethserver-updates: nethserver.antani.co
Resolving Dependencies
--> Running transaction check
---> Package nethserver-mail-common.noarch 0:1.5.2-*1.3*.gdca8ccd.ns6 will be installed


Installing:
 nethserver-mail-common                 noarch             1.5.2-1.3.gdca8ccd.ns6                nethserver-testing              66 k

but the package is not the same as in the instructions.

I went ahead with the install and it's dependencies, verified Email was installed from the gui and a search of /var/log/messages with the above search for "postfix/access.cidr/10smtpaccess", came back false.

So as long as the package is acceptable then this can be set status verified.

#6 Updated by k c about 2 years ago

I don't think I did this right.

I installed Email from the gui to verify the error msg.
Then I reverted the vm and installed from nethserver-testing nethserver-mail-common, while it installed the dependencies for that package it didn't install the full Email so I'm not sure how to go about this.

Should I install nethserver-mail-server from nethserver-testing at the cli?

Sorry I don't know what I'm doing.

#7 Updated by Filippo Carletti about 2 years ago

  • Status changed from ON_QA to VERIFIED
  • % Done changed from 70 to 90

Even if the nethserver-mail-common package version is not the one requested by the test case, verification is possibile, since you have a new version that contains the fix.

[root@nscom ~]# rpm -q --changelog nethserver-mail-common 
* Wed Feb 03 2016 Davide Principi <davide.principi@nethesis.it> - 3.gdca8ccd.ns6
- Reduce cache lifetime for negative responses. Refs #3347 (Davide Principi <davide.principi@nethesis.it>)
- Default value for postfix/AccessBypassList. Refs #3335 (Davide Principi <davide.principi@nethesis.it>)
- Don't cache negative responses. Refs #3347 (Davide Principi <davide.principi@nethesis.it>)

I think that your verification is correct.
Maybe who will verify issue #3347 will notice that the warning disappeared.

I'm setting this to verified based on your testing.
Thank you.

#8 Updated by Giacomo Sanchietti about 2 years ago

  • Assignee deleted (k c)

#9 Updated by Giacomo Sanchietti about 2 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

Released in 6.7/updates:
nethserver-mail-common-1.5.3-1.ns6.noarch.rpm

Released in 7.2.1511/updates:
nethserver-mail-common-1.5.3-1.6.g69695ec.ns7.noarch.rpm

Also available in: Atom PDF