Feature #3208
Hide samba share
| Status: | CLOSED | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | nethserver-samba | |||
| Target version: | v6.7 | |||
| Resolution: | NEEDINFO: | No |
Description
Add an option on every samba share to make "invisible". Users need to type the full share name to see content.
Idea from http://community.nethserver.org/t/option-to-leave-visible-folder-on-the-share-samba/1164
Associated revisions
SmbShareBrowseable: add backward compatibility, fix web ui. Refs #3208
Browseable checkbox: online docs. Refs #3208
History
#1
Updated by Jacob Oliver over 5 years ago
- Category set to nethserver-samba
#2
Updated by Jacob Oliver over 5 years ago
- Assignee set to Jacob Oliver
- Target version set to v6.7
- Resolution set to UPSTREAM
Changes have been pushed to upstream on GitHub, awaiting acceptance of the pull request. I've tested the changes and can confirm that it's working, now just awaiting verification.
#3
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from NEW to TRIAGED
- % Done changed from 0 to 20
#4
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from TRIAGED to ON_DEV
- % Done changed from 20 to 30
- Resolution deleted (
UPSTREAM)
Pull request: https://github.com/NethServer/nethserver-samba/pull/4
#5
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from ON_DEV to MODIFIED
- Assignee deleted (
Jacob Oliver) - % Done changed from 30 to 60
Pull request merged.
#6
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from MODIFIED to ON_QA
- % Done changed from 60 to 70
nethserver-samba-1.5.3-1.11.g66344d8.ns6.noarch.rpm
- On a clean machine, create a shared folder with samba access
- Update the nethserver-samba package
- The shared folder should be still browseable
- Remove the browseable flag
- The share must invisible from a samba client
- After test case 2
- Set the browseable flag
- The share must visible from a samba client
#7
Updated by dz0 0te over 5 years ago
- Assignee set to dz0 0te
#8
Updated by dz0 0te over 5 years ago
- Status changed from ON_QA to TRIAGED
- Assignee deleted (
dz0 0te) - % Done changed from 70 to 20
System and Package Version installed
VM KVM - Clean install of Nethserver 6.7 fully updated
Package Installed: nethserver-samba-1.5.3-1.ns6.noarch
Other Package installed: File server, Web server
Test Original Problem
Feature
Install Updated Package
yum --enablerepo=nethserver-testing update nethserver-samba-1.5.3-1.11.g66344d8.ns6.noarch
Test Results after update
configure ns for test:
created 2 user
-luigi
-mario
created a group
- bros
created 2 share
- nintendo - > group "bros" + allow permission to owning group
- sega -> no group "local user" + allow permission to owning group
windows network set as workstation
pre update:
ok from user, visible from no user
- update package
Test case 1:
On a clean machine, create a shared folder with samba access > Ok
Update the nethserver-samba Package > OK
The shared folder should be still browseable > FAIL
- from windows: as guest no share visible
as mario, the personal folfder
- from webui: both shares have the "browseable" flag unchecked
on nintendo share check "Browseable" and submit - Now is browseable (from user and guest)
on sega share check "Browseable", all ok
Test case 2
Remove the browseable flag > FAIL
The share must invisible from a samba client > FAIL
on nintendo share uncheck "Browseable" and submit:
- in /var/log/messages i didn't see any new log
- re-edit share, and browseable is still checked
- the share are still browseable
same error on sega share
Verified or Reopen
Reopen
Note
#9
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from TRIAGED to ON_DEV
- Assignee set to Giacomo Sanchietti
- % Done changed from 20 to 30
#10
Updated by Giacomo Sanchietti over 5 years ago
- if the browseable flag is not set, the default is to
disabled: this behavior will hide all already configured shares - if the browseable flag is not set, the web interface will not add the checkbox on the browseable field
- the web interface doesn't fire the event when the checkbox changes values
- create a migration fragment which add the browseable properties to all existing shares
- change the template to set browseable enabled if the prop is not set
- change the control type inside the template for the web interface
#11
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from ON_DEV to MODIFIED
- % Done changed from 30 to 60
#12
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from MODIFIED to ON_QA
- Assignee deleted (
Giacomo Sanchietti) - % Done changed from 60 to 70
- nethserver-samba-1.5.3-1.12.g36e2280.ns6.noarch.rpm
- On a clean machine, create a shared folder with samba access
- Update the nethserver-samba package
- The shared folder should be still browseable
- Remove the browseable flag
- The share must invisible from a samba client
- After test case 2
- Set the browseable flag
- The share must visible from a samba client
#13
Updated by Davide Principi over 5 years ago
- Status changed from ON_QA to VERIFIED
- % Done changed from 70 to 90
System and Package Version installed
Package Installed:
Test Original Problemiba1 is listed before upgrade
smbclient //192.168.122.3/iba1 -U first.user%Nethesis,123
Install Updated Package
yum --setopt=http_caching=none --enablerepo=nethserver-testing update nethserver-samba-1.5.3-1.12.g36e2280.ns6.noarch
Test Results after update
All test cases are VERIFIED
Verified Or Reopen
VERIFIED
TODOs: update
- online doc
- admin's manual
- dev's manual
#14
Updated by Davide Principi over 5 years ago
#15
Updated by Giacomo Sanchietti over 5 years ago
- Status changed from VERIFIED to CLOSED
- % Done changed from 90 to 100
- nethserver-samba-1.5.4-1.ns6.noarch.rpm