Bug #3138

Log viewer close goes back to last module instead of back to log viewer

Added by Davide Principi about 3 years ago. Updated about 3 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-base
Target version:v6.6
Security class: Resolution:
Affected version:v6.6-final NEEDINFO:No

Description

From the dashboard page,

  • select log viewer,
  • open log,
  • close log

taken back to dashboard instead of log viewer.

Thanks to @fasttech for reporting this:

nstestlog2.jpg (23.7 KB) k c, 06/17/2015 02:06 PM

nstestlog3.jpg (43 KB) k c, 06/17/2015 02:06 PM


Related issues

Related to NethServer 6 - Bug #3197: Wrong Server Manager menu category order CLOSED

Associated revisions

Revision 5211cf52
Added by Davide Principi about 3 years ago

Only show links to filtered results, when search occurs. Refs #3138

This wants to be a small enhancement.

Revision 63cb4d08
Added by Davide Principi about 3 years ago

Fix "Close" button behaviour. Refs #3138

Added also a "Clear filter" button to Find view.

Revision b8fa61e1
Added by Davide Principi about 3 years ago

Merge branch 'b3138'. Refs #3138

History

#1 Updated by Giacomo Sanchietti about 3 years ago

  • Status changed from NEW to TRIAGED
  • % Done changed from 0 to 20

#2 Updated by Davide Principi about 3 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Davide Principi
  • % Done changed from 20 to 30

#3 Updated by Davide Principi about 3 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Davide Principi)
  • % Done changed from 30 to 60

MODIFIED

  • added "Clear filter" button, to Find view
  • removed link to complete log in filtered view

Test case 1

Check the bug is not reproducible

Test case 2

Check Clear filter button clears the Find view

#4 Updated by Davide Principi about 3 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

In nethserver-testing:
nethserver-base-2.7.1-1.3.gb8fa61e.ns6.noarch.rpm

#5 Updated by Davide Principi about 3 years ago

Davide Principi wrote:

In nethserver-testing:
nethserver-base-2.7.1-1.3.gb8fa61e.ns6.noarch.rpm

@kc (fasttech), would you like to test it? To update to the modified package (after mirrors are synced) type:

    yum --enablerepo=nethserver-testing update nethserver-base-2.7.1-1.3.gb8fa61e.ns6 

#6 Updated by k c about 3 years ago

Looks good, fresh install, verified the issue, installed your package as above and closing a log returns to the log list, cool!

#7 Updated by k c about 3 years ago

  • Assignee set to k c

#8 Updated by Davide Principi about 3 years ago

Thanks k c, if you think the bug is solved, please set the Status=>VERIFIED and Assignee=>blank

Make sure also Test case 2 works!

#9 Updated by k c about 3 years ago

Ok, I missed the extra mods. Tested the orig issue again and it tests as expected, returns to log list after log close, after a reboot post new pkg.

Regarding mods, the 'clear filter' button closes log and returns to the log list. great.

Regarding link to complete log, this is a nitpick, but if a search term is in the log file name it does return a link to the log containing the search term in its name, that seems fine to me, unless it's not what you intended.

Whereas a search term that does not exist in the logs returns a link to the filtered result, which is the command for the search, this is the expected result, I believe, from what I see of the mod.

So, I'm going to release this from qa and set it to verified, if you feel different...

#10 Updated by k c about 3 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (k c)
  • % Done changed from 70 to 90

#11 Updated by Davide Principi about 3 years ago

  • Related to Bug #3197: Wrong Server Manager menu category order added

#12 Updated by Davide Principi about 3 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-updates:
nethserver-base-2.7.2-1.ns6.noarch.rpm

Also available in: Atom PDF