Bug #3049

Integer validator accepts strings containing number and beginning with spaces

Added by Giacomo Sanchietti almost 5 years ago. Updated almost 5 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-httpd-admin
Target version:v6.6
Security class: Resolution:REJECTED
Affected version:v6.5 NEEDINFO:No

Description

Integer validators accept input strings containing spaces and numbers (like " 255" or "255 ").
Affected validator
  • greatThan
  • lessThan
  • integer
  • positive
  • negative

Expected behavior

Validator must fail with strings like " 255" and "255 ".


Related issues

Related to NethServer 6 - Enhancement #3044: MultiWAN: restrict validator for weight field CLOSED
Copied to Nethgui - Bug #3067: Numeric validators accept strings with spaces CLOSED

Associated revisions

Revision c412989e
Added by Giacomo Sanchietti almost 5 years ago

Validators: fix integer validators. Refs #3049

History

#1 Updated by Giacomo Sanchietti almost 5 years ago

  • Category set to nethserver-httpd-admin
  • Status changed from NEW to TRIAGED
  • Target version set to v6.6
  • % Done changed from 0 to 20

#2 Updated by Giacomo Sanchietti almost 5 years ago

#3 Updated by Giacomo Sanchietti almost 5 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

#4 Updated by Giacomo Sanchietti almost 5 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

#5 Updated by Giacomo Sanchietti almost 5 years ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 60 to 70
  • Affected version set to v6.5
Package in nethserver-testing:
  • nethserver-httpd-admin-1.3.6-2.25.g0602ccb.ns6.noarch.rpm

Test case
Check the bug is not reproducible in #3044

#6 Updated by Nicola Rauso almost 5 years ago

  • Assignee set to Nicola Rauso

#7 Updated by Nicola Rauso almost 5 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Nicola Rauso)
  • % Done changed from 70 to 90

Tested: OK

#8 Updated by Davide Principi almost 5 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
  • Resolution set to REJECTED

We must revert the fix as unit tests fail.

It can potentially break other modules as nethserver-mail-server where the lessThan and greatThan validators expects decimal values.

#9 Updated by Davide Principi almost 5 years ago

  • Copied to Bug #3067: Numeric validators accept strings with spaces added

Also available in: Atom PDF