Bug #2993

Password renewal link doesn't use httpd-admin TCPPort

Added by Stefano Zamboni over 4 years ago. Updated over 4 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-directory
Target version:v6.5
Security class: Resolution:
Affected version:v6.5-final NEEDINFO:No

Description

in the password expiring email there's a link to

https://your_server:980/en/UserProfile

even if httpd-admin TCPPort has been changed

when user try to renew his password using the url proposed, he gets an error

to reproduce
config setprop httpd-admin TCPPort 5061
signal-event nethserver-httpd-admin-update

Associated revisions

Revision e503a6b2
Added by Giacomo Sanchietti over 4 years ago

Password expire template: use httpd-admin TCPPort in notification. Refs #2993

Revision c1429ca2
Added by Davide Principi over 4 years ago

Fixed mail headers. Refs #2993

The last line-feed character generates a corrupted mail message. The
fragment must end with "\n"!

History

#1 Updated by Giacomo Sanchietti over 4 years ago

Surely the problem is present, but I have a doubt: should we allow changing the httpd-admin tcp port?
Maybe this kind of change has no side effects, but this scenario has never been analyzed.

#2 Updated by Giacomo Sanchietti over 4 years ago

  • Category set to nethserver-directory
  • Status changed from NEW to TRIAGED
  • Target version set to v6.5
  • % Done changed from 0 to 20
  • Affected version set to v6.5-final

#3 Updated by Giacomo Sanchietti over 4 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

For now, let's fix the bug.

#4 Updated by Giacomo Sanchietti over 4 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

#5 Updated by Giacomo Sanchietti over 4 years ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 60 to 70

Package in nethserver-testing:
nethserver-directory-2.0.5-1.1gite503a6b.ns6.noarch.rpm
nethserver-directory-2.0.5-1.2gitc1429ca.ns6.noarch.rpm

Test case
  • Check the bug is not reproducibile

Code snippet to test generated mail:

use esmith::templates;

my $userRecord = 'goofy';
my $expireTimestamp = '1322465166';
my $recipientAddress = 'goofy@test.local';
my $lang = 'en';

my $message = esmith::templates::processTemplate({
        'MORE_DATA' => {
            userRecord => $userRecord,
            expireTimestamp => $expireTimestamp,
            recipientAddress => $recipientAddress,
        },
        'OUTPUT_TYPE' => 'string',
        'TEMPLATE_PATH' => 'password-expired/' . $lang
});

print $message;

#6 Updated by Davide Principi over 4 years ago

  • Assignee set to Davide Principi

#7 Updated by Davide Principi over 4 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Davide Principi)
  • % Done changed from 70 to 90

VERIFIED

#8 Updated by Davide Principi over 4 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-updates 6.5
nethserver-directory-2.0.6-1.ns6.noarch.rpm

In nethserver-base 6.6
nethserver-directory-2.0.6-1.2gitac9939d.ns6.noarch.rpm

Also available in: Atom PDF