Bug #2914: DHCP: can't modify IP reservation - NethServer 6 - NethServer.org

Bug #2914

« Previous | Next »

DHCP: can't modify IP reservation

Added by Giacomo Sanchietti almost 7 years ago. Updated almost 7 years ago.

Status:

CLOSED

Start date:

Priority:

Normal

Due date:

Assignee:

% Done:

100%

Category:

nethserver-dnsmasq

Target version:

v6.5

Security class:

Resolution:

Affected version:

v6.5-final

NEEDINFO:

Description

After creating an IP reservation, the entry can't be modified because the system raises the following validation error "08:00:27:77:C3:22".

Steps to reproduce

Create an IP reservation
Try to edit the reservation
The save action will fail

Expected behavior

It must be possibile to modify already existing reservations
The validator should work only for new records

Related issues

Associated revisions

Revision 4ad3b3de
Added by Giacomo Sanchietti almost 7 years ago

Web UI: fix reserver-mac validator. Refs #2914

History

#1 Updated by Giacomo Sanchietti almost 7 years ago

Status changed from NEW to TRIAGED
Target version set to v6.5
% Done changed from 0 to 20

Possible fix:

--- /etc/e-smith/validators/actions/mac-not-reserved.ori    2014-10-16 12:04:02.695294505 +0000
+++ /etc/e-smith/validators/actions/mac-not-reserved    2014-10-16 12:07:17.139231887 +0000
@@ -35,7 +35,8 @@
 my $db = esmith::HostsDB->open_ro();
 foreach ($db->get_all_by_prop('type' => 'local')) {
     my $used_mac = $_->prop('MacAddress');
-    if ($used_mac eq $mac) {
+    my $used_ip = $_->prop('IpAddress');
+    if ($used_mac eq $mac && $used_ip ne $ip) {
         exit 1;
     }
 }