Enhancement #2167

Remove external JS libraries from source repositories

Added by Davide Principi over 6 years ago. Updated almost 6 years ago.

Status:CLOSEDStart date:11/11/2013
Priority:NormalDue date:11/12/2013
Assignee:-% Done:

100%

Category:nethserver-httpd-admin
Target version:v6.5-beta3
Resolution: NEEDINFO:No

Description

External JS libraries must be moved out of our source repositories to avoid licensing and source code statistics discrepancies.


Related issues

Related to Nethgui - Feature #2293: Implement Composer PSR-0 autoloader CLOSED 10/28/2013 10/29/2013
Related to NethServer 6 - Enhancement #2330: server-manager redirect on port 980 CLOSED 11/11/2013 11/11/2013

Associated revisions

Revision 8528bd30
Added by Davide Principi about 6 years ago

Load external jQuery objects from the template. Refs #2167

Revision 83bb98b1
Added by Davide Principi about 6 years ago

Removed jQuery, jQuery UI, jquery plugins libraries. Refs #2167

Revision 8c7dbe5c
Added by Davide Principi about 6 years ago

Removed unused dashboard.js file. Refs #2167

Revision f1fdd560
Added by Davide Principi about 6 years ago

Fetch jQuery libraries with composer. Refs #2167

Code is fetched from host code.nethesis.it

Revision b1f8518e
Added by Davide Principi about 6 years ago

Load external jQuery libraries before JS widgets. Refs #2167

jquery.masonry.min.js is an external library and has been removed from
this repository.

Revision 271c5251
Added by Davide Principi about 6 years ago

Shutdown UI module minor fixes. Refs #2167

History

#1 Updated by Giacomo Sanchietti over 6 years ago

  • Target version changed from v6.4-beta2 to ~FUTURE

#2 Updated by Davide Principi about 6 years ago

  • Due date set to 11/12/2013
  • Status changed from NEW to TRIAGED
  • Target version changed from ~FUTURE to v6.5-beta3
  • Start date set to 11/11/2013
  • % Done changed from 0 to 20
  • Estimated time set to 4.00

#3 Updated by Davide Principi about 6 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Davide Principi
  • % Done changed from 20 to 30

#4 Updated by Davide Principi about 6 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Davide Principi)
  • % Done changed from 30 to 60

Now JS and CSS external dependencies are included in nethserver-httpd-admin RPM by composer

See source:nethserver-httpd-admin|composer.json

Modified
  • nethserver-httpd-admin
  • nethserver-base
  • nethserver-nethgui

Test case
UI behaviour must be unchanged

#5 Updated by Davide Principi about 6 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

In nethserver-testing:
nethserver-httpd-admin-1.0.6-11.0gitf1fdd560.ns6.noarch.rpm
nethserver-base-1.4.3-4.0git271c5251.ns6.noarch.rpm
nethserver-nethgui-1.2.4-9.0git8528bd30.ns6.noarch.rpm

#6 Updated by Giacomo Sanchietti about 6 years ago

  • Assignee set to Giacomo Sanchietti

#7 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90
Tested with:
  • nethserver-httpd-admin-1.0.6-12.0git547b73e8.ns6.noarch
  • nethserver-base-1.4.3-12.0git47330fb2.ns6.noarch
  • nethserver-nethgui-1.2.4-13.0gitb814d52a.ns6.noarch

No error on browser console or apache log.

Marking as VERIFIED.

#8 Updated by Davide Principi almost 6 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-updates:
nethserver-samba-1.4.0-1.ns6.noarch.rpm
nethserver-directory-1.3.0-1.ns6.noarch.rpm
nethserver-dnsmasq-1.1.0-1.ns6.noarch.rpm
nethserver-shorewall-1.0.3-1.ns6.noarch.rpm
nethserver-mail-server-1.5.0-1.ns6.noarch.rpm
nethserver-mail-filter-1.1.4-1.ns6.noarch.rpm
nethserver-nethgui-1.3.0-1.ns6.noarch.rpm
nethserver-base-1.5.0-1.ns6.noarch.rpm
nethserver-lib-1.4.0-1.ns6.noarch.rpm
nethserver-httpd-admin-1.1.0-1.ns6.noarch.rpm
nethserver-yum-1.2.0-1.ns6.noarch.rpm
nethserver-ntopng-1.1.0-1.ns6.noarch.rpm

Also available in: Atom PDF