Bug #1923
DNSMasq: dhcp-reservation validator is case-sensitive
| Status: | CLOSED | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | nethserver-dnsmasq | |||
| Target version: | v6.4-beta2 | |||
| Security class: | Resolution: | |||
| Affected version: | v6.4-beta1 | NEEDINFO: | No |
Description
The action ip-mac-address inside dhcp-reservation validator is case-sensitive.
This behavior raises a false validation error if the mac address is saved uppercase in the db.
Related issues
Associated revisions
ip-mac-address validator: make validation case-insensitive. Refs #1923
History
#1
Updated by Giacomo Sanchietti about 8 years ago
Possible patch:
--- /etc/e-smith/validators/dhcp-reservation/S30ip-mac-address.ori 2013-05-09 15:44:32.024485283 +0200
+++ /etc/e-smith/validators/dhcp-reservation/S30ip-mac-address 2013-05-09 15:43:28.190746725 +0200
@@ -44,7 +44,7 @@
my $octet = '[0-9a-fA-F]{2}';
my $bound = (split(/ +/, qx(/sbin/ip neigh show $ip)))[4];
-if( $bound =~ m/$octet(:$octet){5}/i && $bound ne $mac ) {
+if( $bound =~ m/$octet(:$octet){5}/i && $bound ne lc($mac) ) {
exit 1;
}
#2
Updated by Giacomo Sanchietti about 8 years ago
- Status changed from NEW to TRIAGED
- Assignee set to Giacomo Sanchietti
- % Done changed from 0 to 20
Patch tested: it works.
#3
Updated by Giacomo Sanchietti about 8 years ago
- Status changed from TRIAGED to ON_DEV
- % Done changed from 20 to 30
#4
Updated by Giacomo Sanchietti about 8 years ago
- Status changed from ON_DEV to MODIFIED
- % Done changed from 30 to 70
Patch applied.
#5
Updated by Giacomo Sanchietti about 8 years ago
- Status changed from MODIFIED to ON_QA
- % Done changed from 70 to 80
Package in testing: nethserver-dnsmasq-1.0.3-1.ns6.noarch.rpm
#6
Updated by Davide Principi about 8 years ago
- Assignee changed from Giacomo Sanchietti to Davide Principi
#7
Updated by Davide Principi about 8 years ago
- Status changed from ON_QA to VERIFIED
- Assignee deleted (
Davide Principi) - % Done changed from 80 to 100
#8
Updated by Davide Principi about 8 years ago
- Status changed from VERIFIED to CLOSED
- % Done changed from 90 to 100
Moved to nethserver-updates repository