Enhancement #1896

Backup data: remove ForceFull property

Added by Giacomo Sanchietti over 6 years ago. Updated over 6 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-backup-data
Target version:v6.4-beta1
Resolution: NEEDINFO:

Description

Duplicity already knows when a full backup is needed, so there's no need to handle the ForceFull logic into the backup action.

Associated revisions

Revision 75947dc2
Added by Giacomo Sanchietti over 6 years ago

web ui, actions, db defaults: remove ForceFull property. Refs #1896

History

#1 Updated by Giacomo Sanchietti over 6 years ago

Patch:

--- /etc/e-smith/events/actions/backup-data-duplicity    2013-04-18 17:56:30.526212459 +0200
+++ backup-data-duplicity    2013-04-22 19:38:20.869976109 +0200
@@ -35,7 +35,6 @@
 my $dow = $tm->wday;

 my $type = $backupwk->prop('Type') || 'full';
-my $forceFull = $backupwk->prop('ForceFull') || 'enabled';
 my $VFSType = $backupwk->prop('VFSType') || 'UNKNOWN';
 my $fullday = $backupwk->prop('FullDay') || 0;
 my $mntdir = $backupwk->prop('Mount') || '/mnt/backup';
@@ -50,14 +49,8 @@
   # do full
   $opts .= " full ";
 } elsif ($type eq 'incremental') {
-    # execute full if today is the right day or if ForceFull flag is enabled
-    if ( ($dow == $fullday) || ($forceFull eq 'enabled') ) {
-        # do full
-        $opts .= " full ";
-    } else { # execute incremental backup
         # do incremental
        $opts .= " incr ";
-    }
 } else { # nothing to do
     $backup->logger('ERROR',"Backup type unknown - 1");
     exit 1;

#2 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from NEW to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 0 to 30

#3 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 100

Done.

#4 Updated by Davide Principi over 6 years ago

  • Status changed from MODIFIED to CLOSED

Also available in: Atom PDF