Bug #3452

Backup device mounted after upgrade tool reset

Added by Davide Principi 6 months ago. Updated 5 months ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-upgrade-tool
Target version:v6.10
Security class: Resolution:
Affected version:v6.10 NEEDINFO:No

Description

Steps to reproduce

- Install upgrade-tool
- Check the backup device is not mounted
- Start the prepare step
- Abort the upgrade

Expected result

The system must return to the original state:

- the backup device must not be mounted
- the cron daemon is running

Actual result

The backup device is still mounted

Components

nethserver-upgrade-tool-1.1.0-1.ns6.x86_64.rpm


Related issues

Related to NethServer 6 - Feature #3446: Live upgrade procedure CLOSED

Associated revisions

Revision 0d688566
Added by Davide Principi 5 months ago

Cleanup: unmount backup-data destinations (#3)

The post-backup-data invocation during cleanup complements the
pre-backup-data one that occurs during the download action.

This is required to restore the system to a clean state, if the upgrade
procedure is aborted.

See http://dev.nethserver.org/issues/3452
Refs #3452

History

#1 Updated by Davide Principi 6 months ago

  • Description updated (diff)

#2 Updated by Davide Principi 6 months ago

#3 Updated by Davide Principi 5 months ago

  • Status changed from NEW to TRIAGED
  • Assignee set to Davide Principi
  • % Done changed from 0 to 20

#4 Updated by Davide Principi 5 months ago

  • Status changed from TRIAGED to ON_DEV
  • % Done changed from 20 to 30

#5 Updated by Davide Principi 5 months ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

merged

#6 Updated by Davide Principi 5 months ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Davide Principi)
  • % Done changed from 60 to 70

In nethserver-testing 6.10:
- nethserver-upgrade-tool-1.1.0-1.3.g0d68856.ns6.src.rpm
- nethserver-upgrade-tool-1.1.0-1.3.g0d68856.ns6.x86_64.rpm
- nethserver-upgrade-tool-debuginfo-1.1.0-1.3.g0d68856.ns6.x86_64.rpm

#7 Updated by Nicola Rauso 5 months ago

  • Assignee set to Nicola Rauso

#8 Updated by Nicola Rauso 5 months ago

  • Status changed from ON_QA to VERIFIED
  • Assignee changed from Nicola Rauso to Davide Principi
  • % Done changed from 70 to 90

VERIFIED

Aborting the upgrade with the current package you got:

messages:

May  6 10:44:39 nicola6 esmith::event[9246]: Event: nethserver-upgrade-tool-reset 
May  6 10:44:40 nicola6 esmith::event[9246]: resetting bootloader config
May  6 10:44:40 nicola6 esmith::event[9246]: removing boot images
May  6 10:44:40 nicola6 esmith::event[9246]: removing downloaded packages
May  6 10:44:40 nicola6 esmith::event[9246]: removing miscellaneous files
May  6 10:44:40 nicola6 /sbin/e-smith/db[9260]: /var/lib/nethserver/db/configuration: OLD crond=service|status|disabled
May  6 10:44:40 nicola6 /sbin/e-smith/db[9260]: /var/lib/nethserver/db/configuration: NEW crond=service|status|enabled
May  6 10:44:40 nicola6 esmith::event[9246]: Action: /etc/e-smith/events/nethserver-upgrade-tool-reset/S20nethserver-upgrade-cleanup SUCCESS [1.357216]
May  6 10:44:41 nicola6 esmith::event[9246]: Starting crond: [  OK  ]#015
May  6 10:44:41 nicola6 esmith::event[9246]: [INFO] service crond start
May  6 10:44:41 nicola6 esmith::event[9246]: [INFO] crond has been started
May  6 10:44:41 nicola6 esmith::event[9246]: 
May  6 10:44:41 nicola6 esmith::event[9246]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [0.123004]
May  6 10:44:41 nicola6 esmith::event[9246]: Event: nethserver-upgrade-tool-reset SUCCESS

and:

~]# mount | grep backup
//192.168.5.24/shared on /mnt/backup type cifs (rw)

with the new package (nethserver-upgrade-tool-1.1.0-1.3.g0d68856.ns6.x86_64.rpm):

messages:

May  6 11:04:22 nicola6 esmith::event[11471]: Event: nethserver-upgrade-tool-reset 
May  6 11:04:22 nicola6 esmith::event[11471]: resetting bootloader config
May  6 11:04:22 nicola6 esmith::event[11471]: removing boot images
May  6 11:04:22 nicola6 esmith::event[11471]: removing downloaded packages
May  6 11:04:22 nicola6 esmith::event[11471]: removing miscellaneous files
May  6 11:04:23 nicola6 /sbin/e-smith/db[11485]: /var/lib/nethserver/db/configuration: OLD crond=service|status|disabled
May  6 11:04:23 nicola6 /sbin/e-smith/db[11485]: /var/lib/nethserver/db/configuration: NEW crond=service|status|enabled
May  6 11:04:23 nicola6 esmith::event[11486]: Event: post-backup-data 
May  6 11:04:23 nicola6 esmith::event[11486]: Action: /etc/e-smith/events/post-backup-data/S70cleanup-data-duplicity SUCCESS [0.065863]
May  6 11:04:23 nicola6 esmith::event[11486]: Action: /etc/e-smith/events/post-backup-data/S70cleanup-restore-index SUCCESS [0.033681]
May  6 11:04:23 nicola6 esmith::event[11486]: Action: /etc/e-smith/events/post-backup-data/S80umount-cifs SUCCESS [0.053413]
May  6 11:04:23 nicola6 esmith::event[11486]: Action: /etc/e-smith/events/post-backup-data/S80umount-nfs SUCCESS [0.045414]
May  6 11:04:23 nicola6 esmith::event[11486]: Action: /etc/e-smith/events/post-backup-data/S80umount-usb SUCCESS [0.034417]
May  6 11:04:23 nicola6 esmith::event[11486]: Event: post-backup-data SUCCESS
May  6 11:04:23 nicola6 esmith::event[11471]: Action: /etc/e-smith/events/nethserver-upgrade-tool-reset/S20nethserver-upgrade-cleanup SUCCESS [1.408345]
May  6 11:04:23 nicola6 esmith::event[11471]: Starting crond: [  OK  ]#015
May  6 11:04:23 nicola6 esmith::event[11471]: [INFO] service crond start
May  6 11:04:23 nicola6 esmith::event[11471]: [INFO] crond has been started
May  6 11:04:23 nicola6 esmith::event[11471]: 
May  6 11:04:23 nicola6 esmith::event[11471]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [0.111117]
May  6 11:04:23 nicola6 esmith::event[11471]: Event: nethserver-upgrade-tool-reset SUCCESS

and

~]# mount | grep backup
~]#

#9 Updated by Davide Principi 5 months ago

  • Assignee deleted (Davide Principi)

#10 Updated by Davide Principi 5 months ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-updates 6.10:

- nethserver-upgrade-tool-1.1.1-1.ns6.x86_64.rpm
- nethserver-upgrade-tool-debuginfo-1.1.1-1.ns6.x86_64.rpm

* Mon May 06 2019 Davide Principi <davide.principi@nethesis.it> - 1.1.1-1
- Backup device mounted after upgrade tool reset - Bug #3452 [NethServer 6]
- SCLo repositories version lock - NethServer/dev#5689

Also available in: Atom PDF