Bug #3385

User and password with blank spaces in PPPoE configuration

Added by Davide Marini over 3 years ago. Updated over 3 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-base
Target version:v6.7
Security class: Resolution:
Affected version:v6.7 NEEDINFO:No

Description

During the configuration of the PPPOE if one or more blank spaces are wrongly written before the user/pass they will become part of the user/pass value in the database, example with user =" user " and password=" password ", follows what's written in the db:

ppp0=xdsl|AuthType|auto|Password|  *password*    |name|PPPoE|provider|xDSL provider|role|red|user|  *user*

The problem is that the web UI doesn't show blank spaces as you can see on the attached screenshot, so you think that values are correctly written.
The "password" field also holds blank spaces at the end of the value.

Example Org Rete.png (27.2 KB) Davide Marini, 05/02/2016 09:46 AM

Associated revisions

Revision 934c07ff
Added by Giacomo Sanchietti over 3 years ago

PPPoE: trim parameters before saving to db. Refs #3385

History

#1 Updated by Giacomo Sanchietti over 3 years ago

  • Category set to nethserver-base
  • Status changed from NEW to TRIAGED
  • Target version set to v6.7
  • % Done changed from 0 to 20
  • Affected version set to v6.7

#2 Updated by Giacomo Sanchietti over 3 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

#3 Updated by Giacomo Sanchietti over 3 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

All parameters will be trimmed before saving on database.

#4 Updated by Giacomo Sanchietti over 3 years ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 60 to 70
In nethserver-testing:
  • nethserver-base-2.10.2-1.1.g934c07f.ns6.noarch.rpm
Test case
  • Check the bug is not reproducible

#5 Updated by Filippo Carletti over 3 years ago

  • Subject changed from User and password with blank spaces in PPOE configuration to User and password with blank spaces in PPPoE configuration

#6 Updated by Davide Marini over 3 years ago

  • Status changed from ON_QA to VERIFIED
  • % Done changed from 70 to 90

tested and working (user=" user ", password =" password " )

package installed:

nethserver-base-2.10.2-1.1.g934c07f.ns6.noarch

ppp0=xdsl|AuthType|auto|Password|password|name|PPPoE|provider|xDSL provider|role|red|user|user

#7 Updated by Giacomo Sanchietti over 3 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Released in nethserver-updates:
  • nethserver-base-2.10.3-1.ns6.noarch.rpm

Also available in: Atom PDF