Enhancement #3293

Avoid squid restart after squidguard log rotation

Added by Filippo Carletti almost 4 years ago. Updated almost 4 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-squidguard
Target version:v6.7
Resolution: NEEDINFO:No

Description

There's no need to restart squid after squidguard log rotation.

Associated revisions

Revision 123883df
Added by Filippo Carletti almost 4 years ago

logrotate.d/squidGuard: Do not restart squid and use copytruncate. Refs #3293

History

#1 Updated by Filippo Carletti almost 4 years ago

  • Status changed from NEW to TRIAGED
  • Assignee set to Filippo Carletti
  • % Done changed from 0 to 20

logrotate options:

    compress
    notifempty
    missingok
    copytruncate

#2 Updated by Filippo Carletti almost 4 years ago

  • Status changed from TRIAGED to ON_DEV
  • % Done changed from 20 to 30

#3 Updated by Filippo Carletti almost 4 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Filippo Carletti)
  • % Done changed from 30 to 60

#4 Updated by Filippo Carletti almost 4 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

Package in nethserver-testing:
nethserver-squidguard-1.3.3-1.1.g123883d.ns6.noarch.rpm

Test case

After update:

# cat /etc/logrotate.d/squidGuard 
# ================= DO NOT MODIFY THIS FILE =================
# 
# Manual changes will be lost when this file is regenerated.
#
# Please read the developer's guide, which is available
# at https://dev.nethesis.it/projects/nethserver/wiki/NethServer
# original work from http://www.contribs.org/development/
#
# Copyright (C) 2013 Nethesis S.r.l. 
# http://www.nethesis.it - support@nethesis.it
# 
/var/log/squidGuard/urlfilter.log
/var/log/squidGuard/squidGuard.log
{
    compress
    notifempty
    missingok
    copytruncate
}

#5 Updated by dz0 0te almost 4 years ago

  • Assignee set to dz0 0te

#6 Updated by dz0 0te almost 4 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (dz0 0te)
  • % Done changed from 70 to 90

System and Package Version installed
VM KVM - Clean install of Nethserver 6.7 fully updated
Package Installed: nethserver-squidguard-1.3.3-1.ns6.noarch
Other Package installed: DNS and DHCP server,Web filter,Web proxy,Web server

Test Original Problem
Enhancement

Install Updated Package

yum --enablerepo=nethserver-testing update nethserver-squidguard-1.3.3-1.1.g123883d.ns6.noarch

Test Results after update
Test case 1:
before:

/var/log/squidGuard/urlfilter.log
/var/log/squidGuard/squidGuard.log
{
    weekly
    compress
    notifempty
    missingok
    sharedscripts
    postrotate
      /usr/sbin/squid -k reconfigure 2>/dev/null
    endscript
}

after update

# 
/var/log/squidGuard/urlfilter.log
/var/log/squidGuard/squidGuard.log
{
    compress
    notifempty
    missingok
    copytruncate
}

Verified or Reopen
Verified

Note

#7 Updated by Giacomo Sanchietti almost 4 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Released in nethserver-updates:
  • nethserver-squidguard-1.3.4-1.ns6.noarch.rpm

Also available in: Atom PDF