Bug #3004

« Previous | Next »

backup-data fails just after installation

Added by Luca Gasparini over 6 years ago. Updated over 6 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-backup-data
Target version:v6.6-final
Security class: Resolution:
Affected version:v6.5-final NEEDINFO:No

Description

On a clean installation, the data backup is enabled by default but it fails when starting if the administrator doesn't have previously configured it.

Steps to reproduce:
  • On a clean installation install nethserver-backup-data
  • Execute the backup:
    backup-data
  • The return code is 1
  • No error is reported in /var/log/messages
Expected behavior:
  • The backup-data should not be started if not properly configured

Associated revisions

Revision 4d66ddd8
Added by Giacomo Sanchietti over 6 years ago

db defaults: set status to disabled. Refs #3004

Revision 4de5ff26
Added by Giacomo Sanchietti over 6 years ago

Web UI: remove destination tab, stronger validators. Refs #3004

Revision 9b254ab3
Added by Giacomo Sanchietti over 6 years ago

todo.d: add backup check. Refs #3004

Revision b5a8855a
Added by Giacomo Sanchietti over 6 years ago

todo.d: add translations. Refs #3004

Revision 1abd6ad8
Added by Giacomo Sanchietti over 6 years ago

todos: fix wrong path. Refs #3004

History

#1 Updated by Filippo Carletti over 6 years ago

# cat /etc/e-smith/db/configuration/defaults/backup-data/status 
enabled

Status default should be disabled.

#2 Updated by Giacomo Sanchietti over 6 years ago

  • Subject changed from backup-data enabled by default to backup-data fails just after installation
  • Description updated (diff)

#3 Updated by Giacomo Sanchietti over 6 years ago

Following Filippo suggestion, I propose this solution:
  • set the default status to disabled
  • change the web interface: move the "Destination" tab inside the "General" tab

#4 Updated by Filippo Carletti over 6 years ago

Also change line 8 of /etc/e-smith/templates/etc/cron.d/backup-data/10base

#5 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from NEW to TRIAGED
  • % Done changed from 0 to 20
  • Affected version changed from v6.5 to v6.6

#6 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

#7 Updated by Giacomo Sanchietti over 6 years ago

  • Target version set to v6.6
  • Affected version changed from v6.6 to v6.5-final

#8 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

#9 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 60 to 70
Package in nethserver-testing:
  • nethserver-backup-data-1.1.1-1.4.gb5a8855.ns6.noarch.rpm
Test case 1
  • Check the bug is not reproducible
Test case 2
  • On a fresh install, check the backup is disabled and a todo appears in the Dashboard
Test case 3
  • Try to configure the backup using different destinations
  • Check all validators correctly work

#10 Updated by Davide Principi over 6 years ago

  • Assignee set to Davide Principi

#11 Updated by Davide Principi over 6 years ago

  • NEEDINFO changed from No to Yes

Upgrading an existing package leaves the backup enabled:

config getprop backup-data status 
enabled

That's fine for new installations, but no migration fragment is provided for older ones? 

# rpm -ql nethserver-backup-data | grep migrate
/etc/e-smith/db/configuration/migrate
/etc/e-smith/db/configuration/migrate/bug3007.ns6_5

#12 Updated by Davide Principi over 6 years ago

  • Status changed from ON_QA to TRIAGED
  • Assignee deleted (Davide Principi)
  • % Done changed from 70 to 20

NOT VERIFIED

The todo script is in a wrong place. Fixed with 

cp /etc/nethserver/todo{,s}.d/80backup-data

#13 Updated by Davide Principi over 6 years ago

  • Target version changed from v6.6 to v6.6-final

#14 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

#15 Updated by Giacomo Sanchietti over 6 years ago

  • NEEDINFO changed from Yes to No

Upgrading an existing package leaves the backup enabled:[...]

That's fine for new installations, but no migration fragment is provided for older ones? [...]

This is correct, you should not disable an already configured backup.

#16 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 30 to 60

#17 Updated by Giacomo Sanchietti over 6 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70
Package in nethserver-testing:
  • nethserver-backup-data-1.1.1-1.5.g1abd6ad.ns6.noarch.rpm

#18 Updated by Davide Principi over 6 years ago

  • Status changed from ON_QA to VERIFIED
  • % Done changed from 70 to 90

VERIFIED

#19 Updated by Davide Principi over 6 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-base 6.6:
nethserver-backup-data-1.1.2-1.ns6.noarch.rpm

Also available in: Atom PDF