Enhancement #2807

« Previous | Next »

NetworkAdapter: adaptive UI fields

Added by Davide Principi about 7 years ago. Updated almost 7 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-base
Target version:v6.5
Resolution: NEEDINFO:No

Description

The NetworkAdapter page should adapt the input form to the actual task, to help the user doing the right choice:

  • when configuring a blue/orange adapter, hide the Gateway text input field
  • when a role is not red, hide the DHCP radio button (also Static becomes redundant)
  • when deleting a vlan, hide the dropdown selector (no choices can be available)

2807.patch Magnifier (3.74 KB) Giacomo Sanchietti, 10/06/2014 04:41 AM

Associated revisions

Revision 14b60e40
Added by Davide Principi almost 7 years ago

NetworkAdapter UI module: adaptive form of network parameters. Refs #2807

  • hide gateway field if role is neither green nor red
  • hide DHCP/Static radio buttons if role is not red
  • show role label in the header of SetIpAddress
  • hide "Successor" in DeleteLogicalInterface if there isn't any

Revision 625eaa89
Added by Davide Principi almost 7 years ago

NetworkAdapter UI module: fixed successor in Delete form. Refs #2807

Revision be662e9a
Added by Davide Principi almost 7 years ago

DB configuration: migrate interfaces bootproto=static to bootproto=none. Refs #2807

History

#1 Updated by Davide Principi about 7 years ago

  • Status changed from NEW to TRIAGED
  • Target version set to v6.5
  • % Done changed from 0 to 20

#2 Updated by Giacomo Sanchietti almost 7 years ago

Attached patch fixes the points 1 and 2, I couldn't find a simple solution for the third point.

#3 Updated by Davide Principi almost 7 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Davide Principi
  • % Done changed from 20 to 30

#4 Updated by Davide Principi almost 7 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Davide Principi)
  • % Done changed from 30 to 60

Test case

Both Edit and New Interface > Configure IP assignment forms must respect the following rules:

  • hide gateway field if role is neither green nor red
  • hide DHCP/Static radio buttons if role is not red

Moreover check the interface

  • shows role label in the header of New Interface > Configure IP assignment form
  • hides Successor in Delete form there isn't any successor available

You'll need to install nethserver-firewall-base to test all roles!

#5 Updated by Davide Principi almost 7 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

In nethserver-testing:
nethserver-base-2.4.0-10.0git625eaa89.ns6.noarch.rpm
nethserver-base-2.4.0-13.0gitbe662e9a.ns6.noarch.rpm

#6 Updated by Giacomo Sanchietti almost 7 years ago

  • Assignee set to Giacomo Sanchietti

#7 Updated by Giacomo Sanchietti almost 7 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90

All tests passed: also tried creation and removal of bridges and vlan.

#8 Updated by Giacomo Sanchietti almost 7 years ago

  • Status changed from VERIFIED to ON_QA
  • % Done changed from 90 to 70

Back on QA to test new migration fragment.

#9 Updated by Giacomo Sanchietti almost 7 years ago

  • Assignee set to Giacomo Sanchietti

#10 Updated by Giacomo Sanchietti almost 7 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90

Migration works as expected.

Before installing package:

eth0=ethernet
    bootproto=static
    device=eth0
    gateway=192.168.1.100
    hwaddr=xx:xx:27:77:C3:22
    ipaddr=192.168.1.2
    netmask=255.255.255.0
    onboot=yes
    role=green

After:

eth0=ethernet
    bootproto=none
    device=eth0
    gateway=192.168.1.100
    hwaddr=xx:xx:27:77:C3:22
    ipaddr=192.168.1.2
    netmask=255.255.255.0
    onboot=yes
    role=green

#11 Updated by Giacomo Sanchietti almost 7 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Packages released in nethserver-updates:
  • nethserver-base-2.5.0-1.ns6.noarch.rpm

Also available in: Atom PDF