Bug #2720

Fax server: physical modem is not probed

Added by Giacomo Sanchietti over 5 years ago. Updated over 5 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-hylafax
Target version:v6.5
Security class: Resolution:
Affected version: NEEDINFO:No

Description

When a physical modem is connected to the system it is not correctly configured for the fax server.

The nethserver-hylafax-modemsetup doesn't call the probing script for the modem.

Tested patch:

[root@nethservice actions]# diff -u nethserver-hylafax-modemsetup.ori nethserver-hylafax-modemsetup
--- nethserver-hylafax-modemsetup.ori    2014-04-17 08:39:09.925665819 +0200
+++ nethserver-hylafax-modemsetup    2014-04-17 08:39:27.249868312 +0200
@@ -40,7 +40,7 @@
 my $FaxDevice           = $mabase->prop('FaxDevice');

 # execute faxaddmodem only if not using iaxmodem
-if ($FaxDevice =~ '/^ttyIAX/') {
+if (!($FaxDevice =~ '/^ttyIAX/')) {
   system("/usr/sbin/neth-addmodem &> /var/log/addmodem.log");
 }

Associated revisions

Revision cd1125be
Added by Giacomo Sanchietti over 5 years ago

nethserver-hylafax-modemsetup: execute neth-addmodem when configured modem is not IAX modem. Refs #2720

History

#1 Updated by Giacomo Sanchietti over 5 years ago

  • Status changed from NEW to TRIAGED
  • % Done changed from 0 to 20

#2 Updated by Giacomo Sanchietti over 5 years ago

  • Status changed from TRIAGED to MODIFIED
  • % Done changed from 20 to 60

Patch committed.

#3 Updated by Giacomo Sanchietti over 5 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70
Package in nethserver-testing:
  • nethserver-hylafax-1.0.5-1.0gitcd1125be.ns6.noarch.rpm
Test case
  • Install the new package
  • Connect a physical modem
  • Got to the web interface, make any change, and hit the save button
  • Verify the config file is created under /var/spool/hylafax/

#4 Updated by Nicola Rauso over 5 years ago

  • Assignee set to Nicola Rauso

#5 Updated by Nicola Rauso over 5 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Nicola Rauso)
  • % Done changed from 70 to 90

Tested: ok

#6 Updated by Giacomo Sanchietti over 5 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Released:
  • nethserver-hylafax-1.0.6-1.ns6.noarch.rpm:

Also available in: Atom PDF