Enhancement #2103

Base: validate configuration from NetworkAdapter UI module

Added by Davide Principi about 8 years ago. Updated almost 8 years ago.

Status:CLOSEDStart date:08/02/2013
Priority:NormalDue date:08/02/2013
Assignee:-% Done:

100%

Category:nethserver-base
Target version:v6.4-beta2
Resolution: NEEDINFO:No

Description

Implement a platform validator that checks the consistency of the changes to NetworksDB before applying them, to avoid admin's locking-out. See #2075

Related issues

Related to NethServer 6 - Enhancement #2075: Update NetworksDB on udev events CLOSED 08/01/2013 08/02/2013

Associated revisions

Revision 4673417f
Added by Davide Principi about 8 years ago

interface-config validator: added interface-role action. Refs #2103

Revision eeb10427
Added by Davide Principi about 8 years ago

NetworkAdapter UI module: validate interface changes with "interface-config" platform validator. Refs #2103

Revision 6fbdede8
Added by Davide Principi about 8 years ago

NetworkAdapter UI: don't actually delete interface record; set role prop to '' instead. Refs #2103

Revision 819f170b
Added by Davide Principi about 8 years ago

NetworkAdapter UI: remove delete action on unconfigured interfaces. Refs #2103

Revision aba4149b
Added by Davide Principi about 8 years ago

NetworkAdapter UI module: refactored Modify module adding getNicInfo() method. Refs #2103

History

#1 Updated by Davide Principi about 8 years ago

  • Due date set to 08/02/2013
  • Status changed from TRIAGED to ON_DEV
  • Start date set to 08/02/2013
  • % Done changed from 20 to 30

#2 Updated by Davide Principi about 8 years ago

  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Davide Principi)
  • % Done changed from 30 to 60

Modified:
nethserver-base

Test case

In NetworkAdapter UI module, validation must fail if:
  • role is not "red" and DHCP is enabled
  • an attempt to configure the system without a green interface is made

Execute also test case from #2075

NOTE: Nethgui does not show the validator message correctly. This must be fixed there.

#3 Updated by Davide Principi about 8 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70
In nethserver-testing:
  • nethserver-base-1.4.0-12.0git855f8d09.ns6.noarch.rpm
  • nethserver-firewall-base-1.0.4-1.0gitefdc4b76.ns6.noarch.rpm

#4 Updated by Giacomo Sanchietti almost 8 years ago

  • Assignee set to Giacomo Sanchietti

#5 Updated by Giacomo Sanchietti almost 8 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90
  • role is not "red" and DHCP is enabled

Tested with JavaScript disabled: OK.
If JavaScript is enabled, UI will prevent this kind of error.

  • an attempt to configure the system without a green interface is made

Works correctly.

By the way, it is possible to create two or more green interfaces: system will correctly use the first one as green device in all templates.

NOTE: Nethgui does not show the validator message correctly. This must be fixed there.

First validator message is fine:
  • Device: DHCP can be used only with red interfaces
Only the second line is wrong:
  • Device: valid_platform

Marking as VERIFIED.

#6 Updated by Davide Principi almost 8 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

In nethserver-updates:
nethserver-base-1.4.1-1.ns6.noarch.rpm
nethserver-httpd-admin-1.0.5-1.ns6.noarch.rpm
nethserver-firewall-base-1.0.5-1.ns6.noarch.rpm

Also available in: Atom PDF