NethServer 6

All checks on already mounted directory can be safely removed.

Fix applied.

• nethserver-backup-data-1.0.2

ON_QA: Assignee reset

REJECTED

Installed RPMs

    # rpm -qa | grep -F .ns6
nethserver-php-1.1.0-1.ns6.noarch
nethserver-smartd-1.0.0-1.ns6.noarch
nethserver-backup-data-1.0.4-1.ns6.noarch
nethserver-yum-1.1.0-1.ns6.noarch
nethserver-base-1.3.0-1.ns6.noarch
nethserver-nethgui-1.2.1-1.ns6.noarch
nethserver-httpd-admin-1.0.4-1.ns6.noarch
nethserver-grub-1.0.1-1.ns6.noarch
nethserver-openssh-1.0.2-1.ns6.noarch
nethserver-backup-config-1.0.3-1.ns6.noarch
nethserver-lib-1.1.2-1.ns6.noarch
postfix-2.9.6-2.ns6.x86_64
nethserver-ntp-1.0.4-1.ns6.noarch

• Never delete old files
• Mail notifications to external address
• Report ALWAYS
• Full backup

• NFS
  1. With device already mounted on dir different from /mnt/backup => PASS
  2. With device already mounted in /mnt/backup => PASS (also unmounted after backup)
• USB
  1. With device already mounted on dir different from /mnt/backup it reported SUCCESS but files were written into mountpoint dir /mnt/backup => REJECTED
  2. With device already mounted in /mnt/backup => PASS (also unmounted after backup)
  3. Without any device attached same as point 1 => REJECTED
  4. With device attached => PASS
• CIFS
  1. Without mount => PASS
  2. With device already mounted on dir different from /mnt/backup it reported an ERROR "Backup directory is not mounted" => PASS
  3. With device already mounted in /mnt/backup => PASS (also unmounted after backup)

Notes
Mounted dirs should be excluded from the backup (--exclude-other-filesystems arg to duplicity)

1. With device already mounted on dir different from /mnt/backup it reported SUCCESS but files were written into mountpoint dir /mnt/backup => REJECTED

Added a test to check if USB disk is mounted on right directory (this case should not ever happen).

1. Without any device attached same as point 1 => REJECTED

Added a check on USBLabel.

Notes
Mounted dirs should be excluded from the backup (--exclude-other-filesystems arg to duplicity)

Some users have home directories (or ibays) mounted on a separate device like a NAS. We canno't introduce this option without a way to disable it.

• nethserver-backup-config
• nethserver-backup-data

• nethserver-backup-data-1.0.5
• nethserver-backup-config-1.0.4

VERIFIED

Cases:

• USB
  1. With device already mounted on dir different from /mnt/backup => see NOTE
  2. With device already mounted in /mnt/backup => PASS
  3. Without any device attached => PASS
  4. With device attached with USBLabel set => PASS
  5. With device attached but no USBLabel set, error => PASS

NOTE:
I've mounted the device under /root/ext and duplicity enters an infinite loop, trying to backup its own backup set. Ok, this case should never happen. We can file an enhancement in the future.

The event pre-backup-data fails if USBLabel is not set and VFSType is not usb.

Fix:

diff --git a/root/etc/e-smith/events/actions/mount-usb b/root/etc/e-smith/events/actions/mount-usb
index cf00e9b..50bdd78 100755
--- a/root/etc/e-smith/events/actions/mount-usb
+++ b/root/etc/e-smith/events/actions/mount-usb
@@ -33,13 +33,13 @@ sub ldie;

 my $confdb = esmith::ConfigDB->open;
 my $backupwk = $confdb->get('backup-data') or die "No backup-data db entry found\n";
-my $usblabel = $backupwk->prop('USBLabel') || die "No USBLabel set";
 my $VFSType = $backupwk->prop('VFSType') || 'UNKNOWN';
 our $mntdir = $backupwk->prop('Mount') || '/mnt/backup';
 my $err = 0;
 my $mntdone = 0;

 exit 0 unless ($VFSType eq 'usb');
+my $usblabel = $backupwk->prop('USBLabel') || die "No USBLabel set";

 our $b = new NethServer::BackupData();

Changelog:

* Tue Aug 06 2013 Giacomo Sanchietti <giacomo.sanchietti@nethesis.it> - 1.0.6-1.ns6
- Do not raise error on empty USBLabel if VFSType is not usb #2022

• nethserver-backup-data-1.0.6-1

Can be marked as VERIFIED: fix has been tested on a production system.

In nethserver-updates:
nethserver-backup-config-1.0.4-1.ns6.noarch.rpm
nethserver-backup-data-1.0.6-1.ns6.noarch.rpm