Feature #1753

Emphasized visual style for mandatory text input fields

Added by Davide Principi over 8 years ago. Updated over 7 years ago.

Status:CLOSEDStart date:
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-nethgui
Target version:v6.5-rc1
Resolution: NEEDINFO:No

Related issues

Related to NethServer 6 - Enhancement #1705: Base: highlight mandatory fields CLOSED
Related to NethServer 6 - Bug #2679: Error on pseudonym creation CLOSED

Associated revisions

Revision 8bfca751
Added by Davide Principi over 7 years ago

new MandatoryValidatorInterface: adds isMandatory() method to ValidatorInterface(). Refs #1753

The new MandatoryValidatorInterface is temporary and deprecated. It
will be merged into ValidatorInterface in the near future.

The AbstractController::prepareView() method checks if a field value
is mandatory and transfer the state to its view.

Only TextInput widget actually displays the "mandatory" CSS class, for
mandatory fields.

Revision 271e10c3
Added by Davide Principi over 7 years ago

Show an exclamation mark on mandatory INPUT fields. Refs #1753

Revision 39d8fed1
Added by Davide Principi over 7 years ago

TextInput JS wiget: hide mandatory mark if field is not empty. Refs #1753

The state of the widget is updated as the user types and on view
update.

Revision 4f9ffdad
Added by Davide Principi over 7 years ago

CSS: mandatory fields styles. Refs #1753

Fixed border color of fields in error state.

Revision 2c4bfa0d
Added by Davide Principi over 7 years ago

Validator: field is optional if has maxLength >= 0 validator. Refs #1753

History

#1 Updated by Filippo Carletti over 8 years ago

  • Target version changed from v6.4-beta1 to ~FUTURE

#2 Updated by Filippo Carletti almost 8 years ago

  • Target version changed from ~FUTURE to v6.5-beta3

#3 Updated by Davide Principi over 7 years ago

  • Status changed from NEW to TRIAGED
  • % Done changed from 0 to 20

#4 Updated by Filippo Carletti over 7 years ago

  • Target version changed from v6.5-beta3 to v6.5-rc1

#5 Updated by Davide Principi over 7 years ago

  • Target version deleted (v6.5-rc1)

#6 Updated by Davide Principi over 7 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Davide Principi
  • % Done changed from 20 to 30

#7 Updated by Davide Principi over 7 years ago

  • Project changed from NethServer 6 to Nethgui
  • Target version deleted (v6.5-rc1)

Moved to Nethgui

#8 Updated by Davide Principi over 7 years ago

  • Target version set to v1.5.0

#9 Updated by Davide Principi over 7 years ago

  • Project changed from Nethgui to NethServer 6
  • Status changed from ON_DEV to MODIFIED
  • Assignee deleted (Davide Principi)
  • Target version changed from v1.5.0 to v6.5-rc1
  • % Done changed from 30 to 60

Test case

Mandatory text input fields must now be displayed with an exclamation mark on the right.

#10 Updated by Davide Principi over 7 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

nethserver-httpd-admin-1.2.0-5.0git271e10c3.ns6.noarch.rpm
nethserver-nethgui-1.3.2-9.0git8bfca751.ns6.noarch.rpm

#11 Updated by Giacomo Sanchietti over 7 years ago

  • Assignee set to Giacomo Sanchietti

#12 Updated by Giacomo Sanchietti over 7 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90

Mandatory fields are correctly emphasized.

#13 Updated by Giacomo Sanchietti over 7 years ago

Maybe a better implementation should be the use of an asterisk instead of the exclamation mark.
The asterisk seems to be a well-known pattern for required fields in most of web application.

A tooltip explaining the asterisk meaning wold be also appreciated.

#14 Updated by Davide Principi over 7 years ago

  • Status changed from VERIFIED to ON_QA
  • % Done changed from 90 to 70

MODIFIED

  • The mandatory mark (asterisk) is shown if the field is empty.
  • The tooltip appears when the form is submitted.

In nethserver-testing:
nethserver-httpd-admin-1.2.0-6.0git4f9ffdad.ns6.noarch.rpm
nethserver-nethgui-1.3.2-12.0git39d8fed1.ns6.noarch.rpm

#15 Updated by Giacomo Sanchietti over 7 years ago

  • Assignee set to Giacomo Sanchietti

#16 Updated by Giacomo Sanchietti over 7 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90

Mandatory fields are marked with an asterisk which disappears when starting typing inside the field.

Marking as VERIFIED.

#17 Updated by Davide Principi over 7 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100

#18 Updated by Davide Principi over 7 years ago

In nethserver-updates:
nethserver-release-6.5-4.ns6.rc1.noarch.rpm
nethserver-devbox-1.4.0-1.ns6.noarch.rpm
nethserver-backup-data-1.0.9-1.ns6.noarch.rpm
nethserver-base-2.1.0-1.ns6.noarch.rpm
nethserver-directory-2.0.1-1.ns6.noarch.rpm
nethserver-firewall-base-1.1.0-1.ns6.noarch.rpm
nethserver-hosts-1.0.7-1.ns6.noarch.rpm
nethserver-httpd-2.3.0-1.ns6.noarch.rpm
nethserver-httpd-admin-1.2.1-1.ns6.noarch.rpm
nethserver-hylafax-1.0.5-1.ns6.noarch.rpm
nethserver-ibays-2.0.3-1.ns6.noarch.rpm
nethserver-lib-2.0.1-1.ns6.noarch.rpm
nethserver-mail-server-1.6.1-1.ns6.noarch.rpm
nethserver-nethgui-1.4.0-1.ns6.noarch.rpm
nethserver-ntopng-1.1.2-1.ns6.noarch.rpm
nethserver-nut-1.0.7-1.ns6.noarch.rpm
nethserver-openssh-1.0.5-1.ns6.noarch.rpm
nethserver-roundcubemail-0.0.2-1.ns6.noarch.rpm
nethserver-samba-1.4.2-1.ns6.noarch.rpm
nethserver-shorewall-1.0.4-1.ns6.noarch.rpm
nethserver-sogo-thunderbird-1.1.1-1.ns6.noarch.rpm
nethserver-vpn-1.1.2-1.ns6.noarch.rpm
sogo-frontends-1.3.0-1.ns6.noarch.rpm

Also available in: Atom PDF