Bug #3388
Multiwan: provider with space in name breaks firewall configuration
Status: | CLOSED | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 100% | |
Category: | nethserver-firewall-base | |||
Target version: | v6.7 | |||
Security class: | Resolution: | |||
Affected version: | v6.7 | NEEDINFO: | No |
Description
If the user creates a provider with a name containing spaces, the firewall will not start.
Steps to reproduce- Go to the MultiWAN page
- Create a new provider named 'ab c'
- Create another provider named 'de f'
Expected behavior
The configuration must be applied.
Actual behavior
The firewall is not restarted and the configuration is not applied.
Associated revisions
MultiWAN: do not allow provider names with space. Refs #3388
MultiWAN: do not allow provider names with space. Refs #3388
History
#1 Updated by Giacomo Sanchietti about 5 years ago
- Status changed from NEW to TRIAGED
- Target version set to v6.7
- % Done changed from 0 to 20
- Affected version set to v6.7
#2 Updated by Giacomo Sanchietti about 5 years ago
- Status changed from TRIAGED to ON_DEV
- Assignee set to Giacomo Sanchietti
- % Done changed from 20 to 30
#3 Updated by Giacomo Sanchietti about 5 years ago
- Status changed from ON_DEV to MODIFIED
- % Done changed from 30 to 60
Addedd a new validator to block provider names with spaces.
#4 Updated by Giacomo Sanchietti about 5 years ago
- Status changed from MODIFIED to ON_QA
- Assignee deleted (
Giacomo Sanchietti) - % Done changed from 60 to 70
In nethserver-testing:
- nethserver-firewall-base-2.10.4-1.1.g891a00d.ns6.noarch.rpm
- nethserver-firewall-base-ui-2.10.4-1.1.g891a00d.ns6.noarch.rpm
- Check the bug is not reproducible
- The user must be prohibited to add a provider name with spaces
#5 Updated by Davide Marini about 5 years ago
- Status changed from ON_QA to VERIFIED
- % Done changed from 70 to 90
with no update:
May 24 16:00:14 vmdavide67 logger: ERROR:Shorewall restart failed May 24 16:00:14 vmdavide67 esmith::event[11449]: [ERROR] Shorewall restart: ERROR: Invalid providers file entry (too many columns) /etc/shorewall/providers (line 24) May 24 16:00:14 vmdavide67 esmith::event[11449]: Action: /etc/e-smith/events/nethserver-firewall-base-save/S89nethserver-shorewall-restart FAILED: 1 [0.829478] May 24 16:00:14 vmdavide67 esmith::event[11449]: lsm start/running, process 11845 May 24 16:00:14 vmdavide67 esmith::event[11449]: [INFO] lsm has been started May 24 16:00:14 vmdavide67 esmith::event[11449]: May 24 16:00:14 vmdavide67 esmith::event[11449]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [0.323519] May 24 16:00:14 vmdavide67 esmith::event[11449]: Event: nethserver-firewall-base-save FAILED May 24 16:00:14 vmdavide67 esmith::event[11448]: Action: /etc/e-smith/events/firewall-adjust/S20firewall-adjust FAILED: 1 [11.640585] May 24 16:00:14 vmdavide67 esmith::event[11448]: Event: firewall-adjust FAILED
packages installed:
nethserver-firewall-base-2.10.4-1.3.g1f58ad6.ns6.noarch
nethserver-firewall-base-ui-2.10.4-1.3.g1f58ad6.ns6.noarch
with the update the user can't insert a provider with spaces in name.
#6 Updated by Giacomo Sanchietti about 5 years ago
- Status changed from VERIFIED to CLOSED
- % Done changed from 90 to 100
Released in 6.7/nethserver-updates:
- nethserver-firewall-base-2.10.5-1.ns6.noarch.rpm
- nethserver-firewall-base-ui-2.10.5-1.ns6.noarch.rpm