Bug #3196

« Previous | Next »

nethserver-sogo-2.1.17-to-2.3.0-update action returns 1 if executed when not needed

Added by Stefano Fancello about 6 years ago. Updated about 6 years ago.

Status:CLOSEDStart date:
Priority:HighDue date:
Assignee:-% Done:

100%

Category:nethserver-sogo
Target version:v6.6
Security class: Resolution:
Affected version:v6.6-final NEEDINFO:No

Description

The event nethserver-sogo-update fails since nethserver-sogo-2.1.17-to-2.3.0-update actions always returns 1 after the first run.
This bug has no practical consequences but it is very ugly .

Steps to reproduce
  • Upgrade and existing SOGo installation prior to 2.3.0
  • The update doesn't raise any error
  • Execute: signal-event nethserver-sogo-update
  • The event always exists with status code 1 even if there is no real error
Expected behavior
  • If there is no error, the event must exit with success

Associated revisions

Revision 7982231e
Added by Stefano Fancello about 6 years ago

Fix #3196 by returning always 0 in nethserver-sogo-2.1.17-to-2.3.0-update action

History

#1 Updated by Stefano Fancello about 6 years ago

  • Status changed from TRIAGED to MODIFIED
  • % Done changed from 20 to 60

Test case:
exec nethserver-sogo-update and check nethserver-sogo-2.1.17-to-2.3.0-update action exit status

#2 Updated by Stefano Fancello about 6 years ago

  • Status changed from MODIFIED to ON_QA
  • % Done changed from 60 to 70

in nethserver-testing, nethserver-sogo-1.5.3-1.1.g7982231.ns6.noarch.rpm

#3 Updated by Stefano Fancello about 6 years ago

  • Assignee deleted (Stefano Fancello)

#4 Updated by Giacomo Sanchietti about 6 years ago

  • Subject changed from nethserver-sogo-2.1.17-to-2.3.0-update action return 1 if executed when not needed to nethserver-sogo-2.1.17-to-2.3.0-update action returns 1 if executed when not needed
  • Description updated (diff)

#5 Updated by Giacomo Sanchietti about 6 years ago

  • Assignee set to Giacomo Sanchietti

#6 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from ON_QA to VERIFIED
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 70 to 90

Before update:

[root@localhost ~]# signal-event nethserver-sogo-update; echo $?
1

After update:

[root@localhost ~]# signal-event nethserver-sogo-update; echo $?
0

#7 Updated by Stefano Fancello about 6 years ago

  • Status changed from VERIFIED to MODIFIED
  • % Done changed from 90 to 60

#8 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from MODIFIED to CLOSED
  • % Done changed from 60 to 100
Released in nethserver-updates:
  • nethserver-sogo-1.5.4-1.ns6.noarch.rpm

Also available in: Atom PDF