Bug #3113
Fax: cannot set up a physical modem
Status: | CLOSED | Start date: | ||
---|---|---|---|---|
Priority: | High | Due date: | ||
Assignee: | - | % Done: | 100% | |
Category: | nethserver-hylafax | |||
Target version: | v6.6 | |||
Security class: | Resolution: | |||
Affected version: | v6.6-final | NEEDINFO: | No |
Description
A bug inside nethserver-hylafax-modemsetup
action called by nethserver-hylafax-save
event prevents setting up a physical modem.
At line 43
there's a wrong if statement:
if (!($FaxDevice =~ '/^ttyIAX/')) { exit(0); } system("/usr/sbin/neth-addmodem &> /var/log/addmodem.log");
the statement is always true so the script ends and neth-addmodem script is never executed.
Installed pakages:- nethserver-hylafax-1.1.0-1.ns6.noarch
- hylafax-5.2.5-1.nh.x86_64
Associated revisions
nethserver-hylafax-modemsetup: fix wrong logic. Refs #3113
nethserver-hylafax-modemsetup: fix syntax. Refs #3113
History
#1 Updated by Nicola Rauso over 6 years ago
- Description updated (diff)
#2 Updated by Nicola Rauso over 6 years ago
- Subject changed from Fax: cannot set a physical modem to Fax: cannot set up a physical modem
- Description updated (diff)
#3 Updated by Nicola Rauso over 6 years ago
- Description updated (diff)
- Affected version set to v6.6-final
#4 Updated by Giacomo Sanchietti over 6 years ago
- Category set to nethserver-hylafax
- Status changed from NEW to TRIAGED
- Target version set to v6.6
- % Done changed from 0 to 20
#5 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from TRIAGED to ON_DEV
- Assignee set to Giacomo Sanchietti
- % Done changed from 20 to 30
#6 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from ON_DEV to MODIFIED
- Assignee deleted (
Giacomo Sanchietti) - % Done changed from 30 to 60
#7 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from MODIFIED to ON_QA
- % Done changed from 60 to 70
Package in nethserver-testing:
- nethserver-hylafax-1.1.0-1.1.g51a6bfa.ns6.noarch.rpm
- Check the bug is not reproducible
- Install nethserver-iaxmodem
- Check iaxmodem configuration correctly works
#8 Updated by Nicola Rauso over 6 years ago
- Status changed from ON_QA to TRIAGED
- % Done changed from 70 to 20
The new script doesn't work.
Trying to modify modem setting, NethGui generates an error:
Task completed with errors # (exit status )
in /var/log/messages
:
Apr 9 18:18:37 nethserver esmith::event[19605]: Event: nethserver-hylafax-save FAILED Apr 9 18:18:37 nethserver httpd-admin: [ERROR] Nethgui\System\NethPlatform: process on queue `post-process` exited with code 1: /usr/libexec/nethserver/ptrack -j -s '/var/run/ptrack/d8269356bbac8cc99d34dc97909bc611.sock' -d '/var/spool/ptrack/d78409665b348e88.dump' -- /usr/bin/sudo -n /sbin/e-smith/signal-event 'nethserver-hylafax-save'
I think that the problem is caused by an unwanted double parentheses at line 43
:
if ($FaxDevice =~ /^ttyIAX/)) {
#9 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from TRIAGED to ON_DEV
- Assignee set to Giacomo Sanchietti
- % Done changed from 20 to 30
#10 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from ON_DEV to MODIFIED
- Assignee deleted (
Giacomo Sanchietti) - % Done changed from 30 to 60
#11 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from MODIFIED to ON_QA
- % Done changed from 60 to 70
Package in nethserver-testing:
- nethserver-hylafax-1.1.0-1.2.g447e5a3.ns6.noarch.rpm
#12 Updated by Nicola Rauso over 6 years ago
- Assignee set to Nicola Rauso
#13 Updated by Nicola Rauso over 6 years ago
- Status changed from ON_QA to VERIFIED
- Assignee deleted (
Nicola Rauso) - % Done changed from 70 to 90
Test case 1
physical modem configuration works flawlessly
Test case 2
iaxmodem configuration works correctly too
#14 Updated by Giacomo Sanchietti over 6 years ago
- Status changed from VERIFIED to CLOSED
- % Done changed from 90 to 100
Released in nethserver-updates:
- nethserver-hylafax-1.1.1-1.ns6.noarch.rpm