Bug #3010

« Previous | Next »

Trusted "Network address" should be a valid Network prefix

Added by Alessio Fattorini over 6 years ago. Updated about 6 years ago.

Status:CLOSEDStart date:05/15/2015
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:nethserver-base
Target version:v6.6
Security class: Resolution:
Affected version:v6.6 NEEDINFO:No

Description

The panel Trusted Network should check if "Network address" is a valid Network prefix and not just an IP. As described here: http://en.wikipedia.org/wiki/Subnetwork#Determining_the_network_prefix

Steps to reproduce:
  • select panel "Trusted network"
  • new network
  • insert 80.xx.xx.114 into Network address
  • insert 255.255.255.240 into Mask
  • Save
  • Install Cups module

Since IP inserted isn't a valid Network prefix, service like cups can't started, because it can't properly configure "Allow From" value into /etc/cups/cupsd.conf.
Cups reports the error in this way:
Jan 19 09:51:23 nethserver-ps cupsd: Unable to read configuration file '/etc/cups/cupsd.conf' - exiting!

The right "Trusted network" should be 80.xx.xx.112

Associated revisions

Revision e44619c7
Added by Giacomo Sanchietti about 6 years ago

Trusted network: add network validator. Refs #3010

History

#1 Updated by Alessio Fattorini over 6 years ago

  • Subject changed from Network address should be a valid Network prefix to Trusted "Network address" should be a valid Network prefix
  • Category set to nethserver-dnsmasq

#2 Updated by Alessio Fattorini over 6 years ago

  • Description updated (diff)
  • Category changed from nethserver-dnsmasq to nethserver-base

#3 Updated by Alessio Fattorini over 6 years ago

  • Description updated (diff)

#4 Updated by Alessio Fattorini over 6 years ago

  • Description updated (diff)

#5 Updated by Filippo Carletti over 6 years ago

  • Target version set to ~FUTURE

#6 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from NEW to TRIAGED
  • Target version changed from ~FUTURE to v6.6
  • % Done changed from 0 to 20
  • Affected version set to v6.6

#7 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from TRIAGED to ON_DEV
  • Assignee set to Giacomo Sanchietti
  • % Done changed from 20 to 30

#8 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from ON_DEV to MODIFIED
  • % Done changed from 30 to 60

#9 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from MODIFIED to ON_QA
  • Assignee deleted (Giacomo Sanchietti)
  • % Done changed from 60 to 70
Package in nethserver-testing:
  • nethserver-base-2.7.0-1.4.ge44619c.ns6.noarch.rpm
Test case 1
  • Check the bug is not reproducible
Test case 2
  • Add/modify/delete a valid network
  • Check the validator doesn't raise an error

#10 Updated by Vasco Castelo Branco about 6 years ago

  • Assignee set to Vasco Castelo Branco

#11 Updated by Vasco Castelo Branco about 6 years ago

  • Start date set to 05/15/2015

#12 Updated by Filippo Carletti about 6 years ago

  • Assignee changed from Vasco Castelo Branco to Filippo Carletti

#13 Updated by Filippo Carletti about 6 years ago

  • Status changed from ON_QA to VERIFIED
  • % Done changed from 70 to 90

First, I verified the problem, I added a wrong network and I saw:

Message from syslogd@ns65 at May 19 19:22:17 ...
 cupsd: Unable to read configuration file '/etc/cups/cupsd.conf' - exiting!

Then I updated and tried to create a wrong network: I received an error "Invalid network address".

Note: when I deleted the wrong network cups started.

#14 Updated by Giacomo Sanchietti about 6 years ago

  • Assignee deleted (Filippo Carletti)

#15 Updated by Giacomo Sanchietti about 6 years ago

  • Status changed from VERIFIED to CLOSED
  • % Done changed from 90 to 100
Released in nethserver-updates:
  • nethserver-base-2.7.1-1.ns6.noarch.rpm

Also available in: Atom PDF